panel: Don't allow opening hidden menus via keybindings

We shouldn't allow toggling menus that aren't supported by the
current session mode, but as indicators are hidden rather than
destroyed on mode switches, it is not enough to check for an
indicator's existence.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/851

diff --git a/js/ui/panel.js b/js/ui/panel.js
index 3ce95a16a36fda3caf2cb87e750ec1efe72680fb..8a6cb77222c04780d5e7360c1afca57cca5b26cc 100644 (file)
--- a/js/ui/panel.js
+++ b/js/ui/panel.js
@@ -957,8 +957,8 @@ class Panel extends St.Widget {
     }
 
     _toggleMenu(indicator) {
-        if (!indicator) // menu not supported by current session mode
-            return;
+        if (!indicator || !indicator.container.visible)
+            return; // menu not supported by current session mode
 
         let menu = indicator.menu;
         if (!indicator.actor.reactive)